Skip to content

Conversation

@vibhorgoswami
Copy link
Contributor

JIRA Ticket

SDKS-4548

Description

Fix the properties on the callback

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.60%. Comparing base (2b0a1e6) to head (8dfc0c6).

Files with missing lines Patch % Lines
...rc/main/kotlin/com/pingidentity/protect/Protect.kt 50.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #153      +/-   ##
=============================================
- Coverage      47.66%   47.60%   -0.07%     
+ Complexity      1198     1195       -3     
=============================================
  Files            293      293              
  Lines           8553     8548       -5     
  Branches        1166     1166              
=============================================
- Hits            4077     4069       -8     
- Misses          3958     3960       +2     
- Partials         518      519       +1     
Flag Coverage Δ
integration-tests 28.56% <0.00%> (+<0.01%) ⬆️
unit-tests 27.19% <81.81%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vibhorgoswami vibhorgoswami requested a review from spetrov January 20, 2026 19:59
@vibhorgoswami vibhorgoswami self-assigned this Jan 20, 2026
@vibhorgoswami vibhorgoswami marked this pull request as ready for review January 22, 2026 19:58
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - the implementation follows the requirement in the ticket.
However, the ticket seems to be a bit misleading, and some of the new requirements appear to be not applicable to the native SDKs, so let's clarify the questions I put in my comments before merging the PR...

private set

var lazyMetadata: Boolean = false
var agentIdentification: Boolean = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, it is not clear to me if we should include these new 3 "agent" fields - according the a comment in the ticket:

Agent configuration is only applicable to web SDK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the fields then? If they're not being used in our SDK?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vibhorgoswami, it looks like there are many moving parts on the server side. From what I see the callback changes are not finalized... we better hold on with these changes until we get clarity on the requirements...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants