feat: axis labels #461
Open
feat: axis labels #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dd47ea0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
keithluchtel
left a comment
keithluchtel
left a comment
There was a problem hiding this comment.
Does adding a label affect the xScale and yScale range? Do we need to update transformInputData at all?
example/app/dashed-axes.tsx
Outdated
| }} | ||
| domain={{ y: [0, 65] }} | ||
| domainPadding={{ top: 20 }} | ||
| // domainPadding={{ top: 20 }} |
| })(); | ||
|
|
||
| // Calculate vertical offset from axis | ||
| const baseOffset = fontSize * 2 + labelOffset + (yOffset ?? 0); |
for both x and y axis, now we calculate the offset of the axis title by adjusting the axis range to accomodate it.
zibs
force-pushed
the
feat/axis-labels
branch
from
3a8c86f to
2f7fdb3
Compare
|
Hello, what's the status of this? We'd love to use labels in our charts :) |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds axis labels
Fixes #350
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
yarn run check:codeand all checks pass