Making ProblemPrompt.get_prompt return str not StrEnum
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
albertbou92,
maykcaldas,
sidnarayanan and
whitead
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that ProblemPrompt.get_prompt consistently returns a plain str by extracting the .value from any StrEnum cases and adds tests to validate this behavior.
- Returned
.valueforTHINK_ANSWERandANSWERcases instead of the enum members - Introduced
test_problem_promptto assert string outputs for eachProblemPromptvariant
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_model_prompts.py | Added test_problem_prompt to verify get_prompt returns a str and contains expected keywords |
| src/ether0/model_prompts.py | Updated get_prompt to use .value on XMLAnswerPrompts variants |
maykcaldas
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProblemPrompt.get_promptis typed to return astr, and in a few cases it returnsXMLAnswerPromptsvariants.XMLAnswerPrompts.REASONING_ANSWERis aStrEnum, which for all normal usage works fine. Actually the existingTestChatArgumentsand the newly addedtest_problem_promptwork both before and after this PR, and also notemypypasses too.However, I felt it weird that
ProblemPrompt.get_promptwould return aStrEnumin some cases, so this PR updates that.