Removing mentions of prototype dataset's name #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
albertbou92,
geemi725,
maykcaldas,
sidnarayanan and
whitead
There was a problem hiding this comment.
Pull Request Overview
This PR removes internal dataset names, replacing them with more generalized identifiers to ensure open source compliance.
- Updated test identifiers in tests/test_rewards.py to reflect generic ids.
- Modified dataset URL comments in src/ether0/utils.py to remove internal references.
- Adjusted inline comments in src/ether0/models.py to use the new generic naming.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_rewards.py | Replaced internal dataset names with generic ids |
| src/ether0/utils.py | Updated comments to use generic dataset references |
| src/ether0/models.py | Revised inline commentary to remove internal naming |
sidnarayanan
approved these changes
Jun 9, 2025
geemi725
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When open sourcing, I forgot to remove mentions of our internal prototype dataset's name. This PR replaces them with more general versions.