v11: Initialize q_con #318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current tests of GEOSgcm v11 with ifx 2025.2, Debug runs were crashing in dyn_core (in fvdycore) on a line concerning the use of
q_con.Running in a graphical debugger found that
q_conwas full of NaNs. Tracing the code, it was found thatq_conwas never initialized.GEOSgcm v12 Debug did run because the line that v11 failed on was removed by @wmputman.
So this PR initializes
q_contotiny_number. My tests show that GEOSgcm v11 with ifort is zero-diff both with Release and Debug flags.