Skip to content

improve runoff distribution #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

improve runoff distribution #753

wants to merge 5 commits into from

Conversation

@zhaobin74
Copy link
Contributor

@zhaobin74 zhaobin74 commented Jul 11, 2025 •
edited
Loading

This PR adds functionality to replace templated string in JRA55-DO's yaml file corresponding to a particular ocean model resolution. This is necessary for GEOS-ESM/GEOSgcm_GridComp#1136

@zhaobin74 zhaobin74 requested a review from a team as a code owner July 11, 2025 16:33
@zhaobin74 zhaobin74 added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jul 11, 2025
@github-actions
Copy link

github-actions bot commented Jul 11, 2025

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@zhaobin74 zhaobin74 mentioned this pull request Jul 11, 2025
Closed
@zhaobin74
Copy link
Contributor Author

zhaobin74 commented Sep 9, 2025

Can we get this PR merged since its dependency is done? Thanks.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 11, 2025
@mathomp4
Copy link
Member

mathomp4 commented Sep 11, 2025

Can we get this PR merged since its dependency is done? Thanks.

@zhaobin74 It looks like GEOS-ESM/GEOSgcm_GridComp#1136 is not yet in GEOSgcm_GridComp. Is that still a dependency?

@zhaobin74
Copy link
Contributor Author

zhaobin74 commented Sep 11, 2025 •
edited
Loading

Can we get this PR merged since its dependency is done? Thanks.

@zhaobin74 It looks like GEOS-ESM/GEOSgcm_GridComp#1136 is not yet in GEOSgcm_GridComp. Is that still a dependency?

Yes, it is. I thought it is merged along with the one in Ocean GC. @sdrabenh, could you please look into GEOS-ESM/GEOSgcm_GridComp#1136? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhaobin74 @mathomp4