v12: Update Ocean DT at runtime, Lower C12 DT #756
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
Member
Author
|
Also, cc @sshakoor1 |
mathomp4
changed the title
zhaobin74
approved these changes
Aug 28, 2025
Member
Author
|
I guess all of this got in. So I'll just close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds run time code for updating Ocean DTs.
gcm_setupcurrently updatesMOM_override,AGCM.rcandice_in(with this PR) based on the Heartbeat question.But, if a user edits
CAP.rcwith an already made experiment, then those files would not be updated. This PR fixes that.I'm pinging @zhaobin74 and @sinakhani to take a look.
This is the v12 equivalent of #755
ALSO: This PR updates the default heartbeat DT for c12 to 1200s. It was found that if running with the latest MOM6 (see GEOS-ESM/GEOSgcm#945), c12 was not stable for 1 day.
Now, per @sinakhani this might be a function of the bathymetry, in which case, this might be fixed later on. But for now, it's C12, no one does science with this and who cares. This just lets us run a day.