Skip to content

Conversation

@najlkin
Copy link
Contributor

@najlkin najlkin commented Dec 5, 2025

This PR does two things:

  • makes palettes_default.cpp a regular source file instead of inlining it, which is a bad practice and it is hard to debug
  • changes values to float literals to avoid the massive amount of warnings during compilation

@najlkin
Copy link
Contributor Author

najlkin commented Dec 6, 2025

(The CI is going to fail until #348 is merged)

Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @najlkin!

@tzanio tzanio merged commit 9d7eb8c into master Jan 8, 2026
16 of 20 checks passed
@tzanio tzanio deleted the palettes-cleanup branch January 8, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants