Skip to content

Conversation

@JackSwerdlow
Copy link

@JackSwerdlow JackSwerdlow commented Nov 24, 2025

  • This fixes the workflow issue when trying to release
  • Tested locally with act and successfully passes all actions
  • Additionally, this also ensures the develop branch is up to date with master and re-adds support for the now working H6008 devices.

I'm keen to get v2.3.0 released for the added support to H60B2 devices.

Galorhallen and others added 7 commits October 18, 2024 09:31
* Update dev to version 2.0.2

* Feature/new devices (Galorhallen#117)

* Add H612B
* Add H61C2
* Add H605D
* Add H6167
* Update issue template

* add segment number to h61e5 according to app (Galorhallen#116)

* Add support for H6609 (Galorhallen#119)

* Feature/new devices (Galorhallen#124)

* Add H6008
* Add H61B3
* Add H8072

* Manual devices (Galorhallen#125)

Add the capability to manually add a device by it's IP address, bypassing discovery.
Device must still be reachable by unicast scan and update messages.

---------

Co-authored-by: Niklas K. <[email protected]>
Co-authored-by: Jan Novotný <[email protected]>
- This fixes the workflow issue when trying to release
- Tested locally with 'act' and passes test job on release
@JackSwerdlow
Copy link
Author

Some logs to prove it will release correctly if merged into master.

Running glol and act release -j test.

Before:

>glol

*   15fe0e0 - (HEAD -> master, tag: v2.3.0, upstream/master) Release 2.3.0 (31 hours ago) <Galorhallen>
|\  
| * 022b1b9 - (upstream/develop) New devices (#240) (31 hours ago) <Galorhallen>
| * 35fa859 - add H60A6, update H60A4 capabilities (#230) (31 hours ago) <chnliupu>
...
> act release -j test
...
[Upload Python Package/test-3]   ✅  Success - Post snok/install-poetry@v1 [18.129136ms]
[Upload Python Package/test-3] ⭐ Run Complete job
[Upload Python Package/test-3]   ✅  Success - Complete job
[Upload Python Package/test-3] 🏁  Job failed
| Creating virtualenv govee-local-api-HKv0vKsU-py3.11 in /root/.cache/pypoetry/virtualenvs
| Installing dependencies from lock file
| 
| pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock` to fix the lock file.
[Upload Python Package/test-1]   ❌  Failure - Main Install dependencies [658.220721ms]
[Upload Python Package/test-1] exitcode '1': failure
[Upload Python Package/test-1] ⭐ Run Post snok/install-poetry@v1
[Upload Python Package/test-1]   🐳  docker cp src=/home/swerds/.cache/act/snok-install-poetry@v1/ dst=/var/run/act/actions/snok-install-poetry@v1/
[Upload Python Package/test-1]   ✅  Success - Post snok/install-poetry@v1 [17.197588ms]
[Upload Python Package/test-1] ⭐ Run Complete job
[Upload Python Package/test-1]   ✅  Success - Complete job
[Upload Python Package/test-1] 🏁  Job failed
Error: Job 'test' failed

After:

>glol

* 707aeae - (HEAD -> develop, origin/develop, origin/HEAD) Refresh lockfile (3 minutes ago) <Jack Swerdlow>
* e79517c - Update dependancies and refresh lockfile (31 minutes ago) <Jack Swerdlow>
*   15fe0e0 - (tag: v2.3.0, upstream/master, master) Release 2.3.0 (31 hours ago) <Galorhallen>
|\  
| * 022b1b9 - (upstream/develop) New devices (#240) (31 hours ago) <Galorhallen>
| * 35fa859 - add H60A6, update H60A4 capabilities (#230) (31 hours ago) <chnliupu>
...
> act release -j test
...
[Upload Python Package/test-2] ⭐ Run Post snok/install-poetry@v1
[Upload Python Package/test-2]   🐳  docker cp src=/home/swerds/.cache/act/snok-install-poetry@v1/ dst=/var/run/act/actions/snok-install-poetry@v1/
[Upload Python Package/test-2]   ✅  Success - Post snok/install-poetry@v1 [20.396111ms]
collected 14 items                                                             
| 
| tests/test_message.py::test_scan_message PASSED                          [  7%]
| tests/test_message.py::test_color_message_ok PASSED                      [ 14%]
| tests/test_message.py::test_color_clipping PASSED                        [ 21%]
| tests/test_message.py::test_brightness PASSED                            [ 28%]
| tests/test_message.py::test_brightness_clipping PASSED                   [ 35%]
| tests/test_message.py::test_on_off PASSED                                [ 42%]
| tests/test_registry.py::TestDeviceRegistry::test_add_custom_device PASSED [ 50%]
| tests/test_registry.py::TestDeviceRegistry::test_add_discovered_device PASSED [ 57%]
| tests/test_registry.py::TestDeviceRegistry::test_cleanup PASSED          [ 64%]
| tests/test_registry.py::TestDeviceRegistry::test_discovery_custom_device PASSED [ 71%]
| tests/test_registry.py::TestDeviceRegistry::test_get_device_by_fingerprint PASSED [ 78%]
| tests/test_registry.py::TestDeviceRegistry::test_get_device_by_ip PASSED [ 85%]
| tests/test_registry.py::TestDeviceRegistry::test_get_device_by_sku PASSED [ 92%]
| tests/test_registry.py::TestDeviceRegistry::test_remove_discovered_device PASSED [100%]
| 
| ============================== 14 passed in 0.04s ==============================
[Upload Python Package/test-2] ⭐ Run Post Set up Python 3.12
[Upload Python Package/test-1]   ✅  Success - Main Test with pytest [735.851641ms]
[Upload Python Package/test-2]   🐳  docker exec cmd=[/opt/acttoolcache/node/18.20.8/x64/bin/node /var/run/act/actions/actions-setup-python@v4/dist/cache-save/index.js] user= workdir=
[Upload Python Package/test-1] ⭐ Run Post snok/install-poetry@v1
[Upload Python Package/test-1]   🐳  docker cp src=/home/swerds/.cache/act/snok-install-poetry@v1/ dst=/var/run/act/actions/snok-install-poetry@v1/
[Upload Python Package/test-1]   ✅  Success - Post snok/install-poetry@v1 [18.943102ms]
[Upload Python Package/test-1] ⭐ Run Post Set up Python 3.11
[Upload Python Package/test-1]   🐳  docker exec cmd=[/opt/acttoolcache/node/18.20.8/x64/bin/node /var/run/act/actions/actions-setup-python@v4/dist/cache-save/index.js] user= workdir=
[Upload Python Package/test-2]   ✅  Success - Post Set up Python 3.12 [215.937723ms]
[Upload Python Package/test-2] ⭐ Run Complete job
[Upload Python Package/test-2] Cleaning up container for job test
[Upload Python Package/test-1]   ✅  Success - Post Set up Python 3.11 [197.65008ms]
[Upload Python Package/test-1] ⭐ Run Complete job
[Upload Python Package/test-1] Cleaning up container for job test
[Upload Python Package/test-2]   ✅  Success - Complete job
[Upload Python Package/test-2] 🏁  Job succeeded
[Upload Python Package/test-1]   ✅  Success - Complete job
[Upload Python Package/test-1] 🏁  Job succeeded

@JackSwerdlow
Copy link
Author

This does add H6008 back to light_capabilities.py but on my Govee app I actually can set them to work on LAN despite claims from others #161 #179.

Proof here:
image

Running on Govee Home App Version 7.2.20 on from the Google Play store.

@JackSwerdlow JackSwerdlow changed the base branch from develop to master November 25, 2025 00:02
@JackSwerdlow JackSwerdlow changed the base branch from master to develop November 25, 2025 00:04
@JackSwerdlow
Copy link
Author

@Galorhallen I just checked and this should be fine to merge into develop and then merge down into master. Keeps this default branch up to date with the latest releases and also fixes the workflow issues I saw you ran into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants