Bump the minimum required CMake version to 3.16 #8324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulWessel
approved these changes
Jan 23, 2024
Member
|
I think that this can be merge. |
Member
|
yes |
|
Small note at future-proofing, please add a higher-bound as well. The higher bound indicates what version of CMake you are testing in the CI and up to which version can the lower bound be bumped up without expecting regressions. It does not indicate a maximum version of CMake that can be used. My recommendation is to have a Github action that builds with 3 versions of CMake (lowest policy, highest policy, current latest-rc). This will be quite important because CMake will start cutting out support every 3 years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
CMake 2.8.12 was released in 2013, which is more than 10 years ago. Most Linux distros no longer provide CMake 2.8, the only exception is CentOS 7, but CentOS 7 itself will be EOL on Jun 30th, 2024. So now it's safe for us to drop support of CMake 2.8.
This PR bumps the minimum required CMake version to 3.16, which was released in 2019 (https://github.com/Kitware/CMake/releases/tag/v3.16.0). This is also the CMake version provided by Ubuntu 20.04.