-
Notifications
You must be signed in to change notification settings - Fork 234
Add contributing guides for wrapping a GMT module #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxrjones
wants to merge
32
commits into
main
Choose a base branch
from
wrap-module-instructions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2aee14d
Update pull request template
2ace7e9
Start on the instructions for adding new module
031460a
Merge branch 'main' into wrap-module-instructions
293035a
Expand guide for wrapping modules
ae143d0
Add section for adding aliases
a05a8a7
Consolidate list
49538ef
Fix grammar
aea5d95
Merge branch 'main' into wrap-module-instructions
62b8cae
Apply suggestions from code review
0c170b3
Update doc/contributing.md
7d26742
Apply suggestions from code review
seisman 2edf308
Merge branch 'main' into wrap-module-instructions
seisman 6dd7d9e
Merge branch 'main' into wrap-module-instructions
seisman 5f3fd30
Updating
seisman de77f0c
Merge branch 'main' into wrap-module-instructions
seisman 70fa80c
Update contributing guides
seisman 6063abe
Update contributing guides
seisman f36dabe
Update contributing guides
seisman 617ec8d
Merge branch 'main' into wrap-module-instructions
yvonnefroehlich 0c32bd2
Merge branch 'main' into wrap-module-instructions
seisman 9fd0cd8
Apply suggestions from code review
seisman 9f38d88
Fix a typo [skip ci]
seisman a4f508a
Fix typos
seisman 97d6026
Reformat some sentences
seisman ad04b8a
Fix styling
seisman f2a86b8
Remove two unnecessary subsections
seisman 274a2ca
Merge branch 'main' into wrap-module-instructions
seisman dc9c0ff
Minor fix
seisman 6b467f1
Fix styling
seisman da8a2f6
Merge branch 'main' into wrap-module-instructions
seisman 5a90e11
Merge branch 'main' into wrap-module-instructions
seisman 7361961
Merge branch 'main' into wrap-module-instructions
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either track the module updates in a project board (my preference) or an issue, but not both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should abandon the 'Wrapper for
<module-name>' issues entirely or keep the issues/issue-template and just move the checklist to the project board? I think the main benefit of the issues is that from my understanding any GitHub user can open/comment on an issue whereas writing on the project board requires special permissions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the project board works better for tracking the progress of wrapping a module, and that having a separate issue for wrapping the function is a bit redundant. I see what you mean about the benefits of issues being open to everyone, but my thought is that wrapping modules is a pretty routine process and doesn't need to first be raised as an issue (unlike a bug or a feature request). We can add some/all of the GMT modules to the project board to track their process. Users who don't have write permission are still free to open up an issue requesting a module/feature (or a pull request! 🤞) as a way to let us know that a certain feature would be useful to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, issues are also more visible than project boards, so that we may have more potential contributors helping wrap new modules and add more aliases.