-
Notifications
You must be signed in to change notification settings - Fork 233
Update "PyData Ecosystem" to "Scientific Python Ecosystem" #3447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please also update this line:
|
README.md
Outdated
| - Support for rich display in the Jupyter notebook. | ||
| - Integration with the [PyData ecosystem](https://pydata.org/): `numpy.ndarray` or `pandas.DataFrame` for | ||
| data tables, `xarray.DataArray` for grids, and `geopandas.GeoDataFrame` for geographical data. | ||
| - Integration with the [Scientific Python ecosystem](https://scientific-python.org/): `numpy.ndarray` or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it should be "scientific Python ecosystem" following https://scientific-python.org/about/ and https://www.nature.com/articles/s41586-020-2649-2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was also wondering which version we want to use, as I found all three "Scientific Python Ecosystem", "Scientific Python ecosystem", and "scientific Python ecosystem". But going with the one used on the official website makes sense.
| # ``x`` is initialized as an :class:`xarray.DataArray` object. This object provides a | ||
| # wrapper around regular PyData formats. It also allows the data to have labeled | ||
| # dimensions while supporting operations that use various pieces of metadata. The | ||
| # following code uses :func:`pandas.date_range` to fill the DataArray with data, but | ||
| # this is not essential for the creation of a valid DataArray. | ||
| # wrapper around regular scientific Python formats. It also allows the data to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This object provides a wrapper around regular scientific Python formats.
I'm unsure what "scientific Python formats" means. The official documentation (https://docs.xarray.dev/en/stable/generated/xarray.DataArray.html) says:
DataArray provides a wrapper around numpy ndarrays that uses labeled dimensions and coordinates to support metadata aware operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Actually I was already a bit confused by "regular PyData formats". So, I just replaced the term. Maybe we should rewrite this sentence to something similar as in the official xarray docs, please see commit 2773524.
seisman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks.good to me. I have updatedthe PR title to reflect the main changes.
Description of proposed changes
Using "Scientific Python ecosystem" instead of "PyData ecosystem" following the discussion in issue #3442.
Fixes #3442
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code