Skip to content

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Nov 7, 2025

Goal

AND-880

As the title says.

Note: I'm not running spotlessApply here to avoid bundling the migration with all the Spotless changes. I'll do it in a follow up (#143). What will change:

  • The headers will add an empty line -> This is how chat & video were configured, so I used their template to minimize the overall changes, since core & feeds' codebases are smaller
  • XML files now get the license header too

Implementation

Replace local Spotless configuration with the convention.

Testing

Run spotlessApply and verify that the files are updated accordingly.

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@gpunto gpunto requested a review from Copilot November 7, 2025 09:47
@gpunto gpunto added the pr:internal Internal changes / housekeeping label Nov 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from a manual Spotless plugin configuration to using a centralized convention plugin (streamConventions 0.3.0). The changes eliminate custom license management tasks and delegate formatting responsibilities to the convention plugin.

  • Removes direct Spotless plugin dependency in favor of stream-project convention plugin
  • Updates streamConventions version from 0.1.1 to 0.3.0
  • Deletes license template files and custom license generation tasks

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
gradle/libs.versions.toml Updates streamConventions version to 0.3.0, removes spotless plugin reference, and adds stream-project plugin
build.gradle.kts Replaces manual spotless configuration with streamProject DSL, removes custom license generation tasks and unused imports
config/license/license.template Removes license template file (now handled by convention plugin)
config/license/generated/license-2025.txt Removes generated license file (now handled by convention plugin)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-feeds-android-client 2.36 MB 2.36 MB 0.00 MB 🟢

@gpunto gpunto marked this pull request as ready for review November 7, 2025 13:36
@sonarqubecloud
Copy link

@gpunto gpunto merged commit a723ca2 into develop Nov 10, 2025
6 of 7 checks passed
@gpunto gpunto deleted the plugins.spotless branch November 10, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:internal Internal changes / housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants