-
Notifications
You must be signed in to change notification settings - Fork 39
chore(types): use 'import type' for type-only imports in SDK #1929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(types): use 'import type' for type-only imports in SDK #1929
Conversation
|
hi @lightning-sagar, thank you for your effort and contribution. Before moving forward I'd like to ask you sign this CLA: Afterwards, to make this future-prone and performant, can you please update our TS config files and enable the I expect |
|
Hi @oliverlaz, I’ve addressed the changes you requested... however, after running |
…sagar/stream-video-js into fix/import-type-usage
|
Hi @oliverlaz , I’ve pushed the latest changes,everything is now updated as requested... |
|
hey @lightning-sagar, I don't expect to see "unused variables" issues. Can you please share a sample output here? |
|
hi @oliverlaz , sorry for the earlier confusion! just to clarify, the warnings I mentioned are related to unused external imports (e.g., Observable, Subject from rxjs, and UnaryCall from @protobuf-ts/runtime-rpc) these are showing up during the build but dont block or break it... ✅ I’ve completed all requested changes:
is there anything else you'd like me to address, or are we good to proceed with the review/approval??? |
|
hi @oliverlaz , Thanks! |
|
Hi @lightning-sagar, thanks for your contributions. |
|
hi @lightning-sagar, do you mind solving the remaining conflicts before we continue merging your contribution? |
|
Hi @lightning-sagar, apologies for the late answers. Would you like to update it and then quickly merge it? One important thing to note is, there shouldn't be any changes in the lock file too. |
|
hi @oliverlaz , sorry for the trouble earlier. at that time i wasnt very familiar with open source workflow and pr hygiene, and i realize it caused extra work for you... |
|
@oliverlaz are these ci failures related to this pr? a few seem to be failing due to missing .env/secrets, others are lint related (they pass locally for me), and the pr title check that you have already fixed.. |
|
hi @lightning-sagar, the CI failures are caused by our linters. |
|
@oliverlaz ,i ran |
Summary
This PR fixes incorrect type imports in the @stream-io/video-react-sdk.
All type-only imports now use
import typeinstead of a regularimport, following TypeScript best practices.Changes
Why
Closes #1928