-
Notifications
You must be signed in to change notification settings - Fork 55
Added reCaptcha module #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iswariya
wants to merge
5
commits into
main
Choose a base branch
from
874-recaptcha-module
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
9 changes: 9 additions & 0 deletions
9
config/sync/captcha.captcha_point.contact_message_personal_form.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| uuid: 99f9c715-53d9-4827-946d-736516318f9a | ||
| langcode: en | ||
| status: false | ||
| dependencies: { } | ||
| _core: | ||
| default_config_hash: 7zUmOK1ti1l0bc78ieysHa3_57MOin7IgHpHhwbSugs | ||
| formId: contact_message_personal_form | ||
| captchaType: default | ||
| label: contact_message_personal_form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| uuid: c64bd524-122c-40e1-98cc-43de63f68573 | ||
| langcode: en | ||
| status: false | ||
| dependencies: { } | ||
| formId: node_landing_page_form | ||
| captchaType: default | ||
| label: node_landing_page_form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| uuid: 6016d008-b564-453b-92e3-ebd16b05a040 | ||
| langcode: en | ||
| status: false | ||
| dependencies: { } | ||
| formId: node_news_form | ||
| captchaType: default | ||
| label: node_news_form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| uuid: b2d8eaea-c507-4f86-9b86-74078dbb024e | ||
| langcode: en | ||
| status: false | ||
| dependencies: { } | ||
| _core: | ||
| default_config_hash: XbughDuwgOtc_8ztmYxz84gaXBeR760xH3bGSKD9v1Q | ||
| formId: user_login_form | ||
| captchaType: default | ||
| label: user_login_form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| uuid: 94c9d6b9-b605-454e-972f-247394f5d810 | ||
| langcode: en | ||
| status: false | ||
| dependencies: { } | ||
| _core: | ||
| default_config_hash: qZeHI5fZ9WQRKsfl8FMBwzk3puSsWCRtWKEZh04JJUo | ||
| formId: user_pass | ||
| captchaType: default | ||
| label: user_pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| uuid: 330e1fc9-9804-4d04-acb5-dbd56818c8e7 | ||
| langcode: en | ||
| status: false | ||
| dependencies: { } | ||
| _core: | ||
| default_config_hash: 2iz3cMg7T1eSKXtNIB9WyaRptfg7wosDDPBSBhXFXl0 | ||
| formId: user_register_form | ||
| captchaType: default | ||
| label: user_register_form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| _core: | ||
| default_config_hash: hfqTr6E3eXAcVQU25_tYHa4BzsSDaYhwkoF34xq5_k4 | ||
| langcode: en | ||
| enable_globally: 0 | ||
| enable_globally_on_admin_routes: false | ||
| default_challenge: recaptcha/reCAPTCHA | ||
| description: 'This question is for testing whether or not you are a human visitor and to prevent automated spam submissions.' | ||
| title: '' | ||
| administration_mode: false | ||
| administration_mode_on_admin_routes: false | ||
| whitelist_ips: '' | ||
| wrong_captcha_response_message: 'The answer you entered for the CAPTCHA was not correct.' | ||
| default_validation: 1 | ||
| persistence: 1 | ||
| enable_stats: false | ||
| log_wrong_responses: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| _core: | ||
| default_config_hash: ByOVf1cU9r5NkZ4ieBJ7k9sUid6jb03ojMN1gjJ0-OU | ||
| site_key: '' | ||
| secret_key: '' | ||
| verify_hostname: false | ||
| use_globally: false | ||
| widget: | ||
| theme: light | ||
| type: image | ||
| size: '' | ||
| noscript: false | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it require the key to work?
Will it work on different envs (local/ QA/ TEST/ LIVE)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitaibu Yes, it requires a key to work. Also, we can add multiple domains to the same site setup in reCAPTCHA, so it doesn’t require separate keys for each environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, then shouldn't we have the key as part of the config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I received a notification from GitGuardian that the reCAPTCHA key was exposed on GitHub. That’s why I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, this is the drupal-starter repo :)
Since it was already exposed on Git, you should revoke those keys and create new ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitaibu As per my understanding, no action is needed on this PR. I will proceed to revoke the site keys in reCAPTCHA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update README, as Captcha won't work without the keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitaibu Updated README.md
TB: 0.15h(0.65h/1h)