Fix test_syntax.sh to skip non-PHP files #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use file command to detect actual PHP files before linting, preventing parse errors on patch files and other non-PHP content. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
mariano-dagostino
approved these changes
Oct 29, 2025
ci-scripts/test_syntax.sh
Outdated
| php -l "$FILE" | ||
| # Only lint actual PHP files using the file command | ||
| if file "$FILE" | grep -q "PHP script"; then | ||
| echo "$FILE" |
There was a problem hiding this comment.
I don't think we need to print the file here. as php linter already includes the file name:
No syntax errors detected in web/index.php
Co-authored-by: Mariano D'Agostino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code