Skip to content

Conversation

@capuleto
Copy link

Message subscribe does not use "last uid" at all when the list of user IDs is provided and range is enabled in subscribe options.
https://www.drupal.org/node/2256899

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. can we avoid running cron, and invoke the needed function ourself?

@capuleto
Copy link
Author

I have queued to patches to test bot since Travis build fails.
Only tests: https://qa.drupal.org/pifr/test/1186683
Patch and tests: https://qa.drupal.org/pifr/test/1186688

@amitaibu I'll update the request if you have any suggestions on how to check for sent emails without using the capture functionality built-in Simpletest.

@amitaibu
Copy link
Member

amitaibu commented Dec 3, 2015

Tests seem to be failing because Travis needs to be updated - drush should be installed via composer now.

@ordavidil can you please review.

@ordavidil
Copy link

@capuleto
Sorry for the delay, just updating you that I'm already on it...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capuleto
This is OK assuming last uid is in the uids array,
but if not,
then $index = 1 as default.

@amitaibu
Can we live with that assumption ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we live with that assumption ?

You'll have to check, and I don't remember :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capuleto
Can you please add a check that determine if the last uid is in the uids array?
If it's not then just use same fallback (set $index = 0;) and add this scenario to the docs.

If you can add a test for that scenario as well it can be awesome :)

@amitaibu
This should cover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants