Improved index #42
Open
Improved index #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fellen
reviewed
Jan 1, 2021
index.phtml
Outdated
Comment on lines
35
to
37
| "<a href=\"download.phtml#previous\">".$last_win7_version."</a>", "Windows 7", "macOS 10.12" )?> | ||
| </p> | ||
| <p><?php printf(T_("Version %s is the last version for Windows XP/Vista and MacOS X 10.8 and earlier, and so the last version that will run on PowerPC Macs."), | ||
| <p><?php printf(T_("Version %s is the last version for Windows XP/Vista and macOS 10.8 and earlier, and so the last version that will run on PowerPC Macs."), |
Member
There was a problem hiding this comment.
No, that was the official writing of that releases.
comradekingu
commented
Jan 1, 2021
Member
|
To be utterly pedantic, Snow Leopard was OS X 10.8. |
fellen
reviewed
Jan 1, 2021
index.phtml
Outdated
Comment on lines
35
to
37
| "<a href=\"download.phtml#previous\">".$last_win7_version."</a>", "Windows 7", "MacOS 10.12" )?> | ||
| "<a href=\"download.phtml#previous\">".$last_win7_version."</a>", "Windows 7", "macOS 10.12" )?> | ||
| </p> | ||
| <p><?php printf(T_("Version %s is the last version for Windows XP/Vista and MacOS X 10.8 and earlier, and so the last version that will run on PowerPC Macs."), | ||
| <p><?php printf(T_("Version %s is the last version for Windows XP/Vista and MacOS 10.8 and earlier, and so the last version that will run on PowerPC Macs."), |
Member
There was a problem hiding this comment.
comradekingu
commented
Jan 1, 2021
| <?php // FIXME: I18N printf, markup: ?> | ||
| <?=T_("Looking for someone to contact about <span class=\"gnucash\">GnuCash</span>? Try the")?> | ||
| <a href="https://wiki.gnucash.org/wiki/Mailing_Lists"><?=T_("Mailing Lists")?></a> | ||
| <?=T_(", which are public, email-based discussion groups where you can ask and answer <span class=\"gnucash\">GnuCash</span> questions to other users.")?> |
Contributor
Author
There was a problem hiding this comment.
There is a whitespace after "Mailing Lists" on https://www.gnucash.org for some reason.
comradekingu
commented
Jan 1, 2021
sunfish62
reviewed
Jan 2, 2021
| <?=T_("Looking for someone to contact about <span class=\"gnucash\">GnuCash</span>? Try the")?> | ||
| <a href="https://wiki.gnucash.org/wiki/Mailing_Lists"><?=T_("Mailing Lists")?></a> | ||
| <?=T_(", which are public, email-based discussion groups where you can ask and answer <span class=\"gnucash\">GnuCash</span> questions to other users.")?> | ||
| <?=T_(", which are public, e-mail-based discussion groups where you can ask and answer <span class=\"gnucash\">GnuCash</span> questions to other users.")?> |
Contributor
There was a problem hiding this comment.
"email" is valid, and is the predominant form used in the English-speaking Gnucash community.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.