Skip to content
This repository was archived by the owner on May 8, 2025. It is now read-only.

Conversation

@abroskin
Copy link

@abroskin abroskin commented Nov 9, 2020

related-issue: #367

  • Added savepointsDir, hadoopConfig, gcpConfig configs to flinkjobcluster helm chart.
  • Fixed the job.args configuration from previously hardcoded value.

…ster helm chart.

- Fixed the job.args configuration from previously hardcoded value.
@google-cla
Copy link

google-cla bot commented Nov 9, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@abroskin abroskin changed the title Hardcoded job.args value in flink-job-cluster helm chart #367 Hardcoded job.args value in flink-job-cluster helm chart Nov 9, 2020
@abroskin
Copy link
Author

abroskin commented Nov 9, 2020

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Nov 9, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@functicons
Copy link
Contributor

@abroskin thanks for the PR! but seems you are using a different email other than your GitHub email in the commit, they need to be the same to sign CLA.

@functicons
Copy link
Contributor

@abroskin could you update the commit with correct email? The CLA is still not signed yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants