Skip to content

Make Object definition cloning explicitly in-file only

b4dcb53
Select commit
Loading
Failed to load commit list.
Merged

Make npc and object definition cloning explicilty not cross-file #866

Make Object definition cloning explicitly in-file only
b4dcb53
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 28, 2026 in 1s

37.15% (+0.00%) compared to a691dcd

View this Pull Request on Codecov

37.15% (+0.00%) compared to a691dcd

Details

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.15%. Comparing base (a691dcd) to head (b4dcb53).

Files with missing lines Patch % Lines
...gs/voidps/engine/data/definition/NPCDefinitions.kt 60.00% 2 Missing ⚠️
...voidps/engine/data/definition/ObjectDefinitions.kt 60.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...gs/voidps/engine/data/definition/NPCDefinitions.kt 62.26% <60.00%> (+2.26%) ⬆️
...voidps/engine/data/definition/ObjectDefinitions.kt 65.90% <60.00%> (+2.49%) ⬆️
@@            Coverage Diff            @@
##               main     #866   +/-   ##
=========================================
  Coverage     37.15%   37.15%           
  Complexity     7263     7263           
=========================================
  Files          1506     1506           
  Lines         59210    59216    +6     
  Branches      14930    14930           
=========================================
+ Hits          21997    22003    +6     
  Misses        32251    32251           
  Partials       4962     4962           
Components Coverage Δ
Content 34.38% <ø> (ø)
Engine 42.81% <60.00%> (+0.03%) ⬆️
Network 60.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.