refactor: add strong typing to Send UI message #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the type within
Message::SendfromStringto a newSendDestinationtype, which is an enum containing either aBolt11Invoice,LnUrl, orbitcoin::Address. This forces the parsing of connection strings to be moved from the message processing code to the message creation code. This has two positive effects:.on_press_maybe(), which disables the button unless a validSendDestinationcan be parsedEssentially, rather than allowing for the "Send" button to be pressed at any time, but presenting error toasts if pressed with an unparseable value, we now disable this button from even being pressed unless a parseable value is entered