-
Notifications
You must be signed in to change notification settings - Fork 152
[Enhancement] QuickStart Menu #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Eblo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README will need updated to reference Quick Start instead of the menu bar. Heck, it needs updated to reference the Esc menu too lol
| result.push_back(D_808141F0[64]); | ||
| continue; | ||
| } | ||
| result.push_back(0xFF); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is the terminator character for the name string, but is this defined anywhere?
Co-authored-by: Eblo <[email protected]>
Co-authored-by: Eblo <[email protected]>
Eblo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something bizarre happens if you try to make a new file when all 3 slots are already populated. Indeed, no file gets created as expected, but the menu gets into a weird state where it highlights two nonexistent options at the same time. If the player tries to manually create a new save in this state, no file gets created, but if rando is enabled, a seed and spoiler log do get generated albeit are not used.
As mentioned on Discord, there's a bug with using the file delete for slots 2 and 3. The correct file is deleted, but the file select menu acts as if slot 1 was deleted.
quickstart.mp4
| } | ||
|
|
||
| void QuickStartQuestInit(const char* fileNameEntry) { | ||
| std::string cleanFileName = Ship_RemoveSpecialCharacters(fileNameEntry); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the change to make this non-static was made, yet I'm still getting the issue where subsequent files will always have the first name I made in the runtime, even if I type something else.
From fresh install to playing in less than 15 seconds. The QuickStart menu will ask you a few questions about what you want to do then creates a file with those options and drops you in game immediately.
The menu will also give you the option to set a curated preset that will enable a majority of the most common Quality of Life enhancements.
I hijacked the F1 hotkey to take you straight to the QuickStart menu from wherever in the Menu you are currently or even if the Menu is not opened. (This may need a change in LUS but I cannot confirm yet)
Build Artifacts