Combine check identity structs into CheckIdentity #5852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Not sure if it's this PR for it being based on older SoH, but catching a fairy with a check in a bottle does not reward the check |
serprex
force-pushed
the
one-identity
branch
from
df514e3 to
87f5c7b
Compare
Contributor
Author
|
tested on dev: this matches upstream behavior |
Pepper0ni
approved these changes
Dec 13, 2025
Contributor
Pepper0ni
left a comment
Pepper0ni
left a comment
There was a problem hiding this comment.
the stated issue was the only one i noticed in testing, and as that is upstream, that means this LGTM
serprex
force-pushed
the
one-identity
branch
4 times, most recently
from
6ea0bbb to
3fdbec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Build Artifacts