-
Notifications
You must be signed in to change notification settings - Fork 628
Randomizer - Shuffle Roll #5956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
TODO New model for items
|
@Pepper0ni was thinking we could make this progressive (no roll, bonk KO, no bonk KO) I've been hesitant here since figuring out what logic depends on rolling jumps will be tedious For custom model, a dice should be straightforward, but maybe a bit too much lateral thinking. An arrow going in a circle should be enough (edit: didn't see you already cobbled together a custom model, that works too) |
soh/soh/Enhancements/game-interactor/vanilla-behavior/GIVanillaBehavior.h
Outdated
Show resolved
Hide resolved
|
This does sound like a good time to implement bonk damage logic, and can agree with wanting BONKO first then everything else to minimize navigation logic headaches. I think we will want to handle the various "basic movement" shuffles together as we can check for everything at the same time. |
…aBehavior.h Co-authored-by: Philip Dubé <[email protected]>
so this would have to be done on another branch and by who? |
Co-authored-by: Philip Dubé <[email protected]>
|
from memory I think I have a line that is no longer useful in draw.cpp that I can remove but I will do that later |
serprex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5987 is an example of trick using rolling jump, but I've been paying attention lately & I don't see rolling jumps being base logic. I think we can merge this as is. There is the question of tricks involving setups that involve rolls/siderolls. But okay for that to be out of scope
| ROLL_ANIMATION_LIMBS); | ||
| } | ||
|
|
||
| // Animation manuelle avec les frames capturées |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments should be English
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups sorry
| #define ROLL_ANIMATION_FRAMES 20 | ||
| #define ROLL_ANIMATION_LIMBS 22 | ||
|
|
||
| static const Vec3s rollAnimationData[ROLL_ANIMATION_FRAMES][ROLL_ANIMATION_LIMBS] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where did this data come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had done a piece of work to capture the animation of link when he rolls and then I retrieved the results of capturing the data to use them for the model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be useful to have that made available somewhere so we can apply it for other shuffle items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, well I'll put it in a separate file so the other developers can use it.
Add new setting randomizer "Shuffle Roll", shuffle ability do a roll for Link
Logic update for Tree and Break Crates
I am not against feedback or ideas for the custom model
And for All language Translation
And for logic
RollAnimation.mp4
Build Artifacts