Skip to content

Conversation

@xxAtrain223
Copy link
Contributor

@xxAtrain223 xxAtrain223 commented Dec 19, 2025

Stringified more logic conditions so they can be used in the Logic Tracker.

Build Artifacts

Copy link
Contributor

@serprex serprex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with more logic moving into EventAccess & Entrances this'll be useful. Logic viewer really needs to render chain of regions in area to reach check. As for rendering EventAccess I'm not sure

(eg #6027 where windmill PoH location now appears twice, only requiring boomerang or nothing)

@xxAtrain223
Copy link
Contributor Author

I think the Logic Tracker already has that covered. e.g. The Kakariko cow, it's in two locations in two regions, and access can be viewed from the entrance chains.
image

@xxAtrain223
Copy link
Contributor Author

Ping me if you want to merge this, and I'll fix the conflicts.
Here's the regex I use to convert 95% of the constructors to macros.

Entrance\(\s*([A-Za-z0-9_]+)(\s*,\s*)\[\]\{return (.*?);\}\s*(,.*?)?\),
ENTRANCE($1$2$3$4),

EventAccess\(\s*([^\s,]+)(\s*,\s*)\[\]\s*\{\s*return (.*?);\s*\}\s*\),
EVENT_ACCESS($1$2$3),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants