Updates #139
Open
Updates #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linting: Lint `/examples` files also (using `overrides` to allow `console` therein) - Refactoring: Switch to ES6 in examples and docs - npm: Update airbnb to version advertised as compatible with exiting eslint version
…xample (also renaming variable to reflect lack of specificity to route of web socket server) - Fix: Allow middleware error handler (arity 4) to be triggered - Refactoring: Remove `upgradeReq` check (dropped back in ws 3) - Testing: Add mocha/chai/nyc Re: middleware error handler, `Layer.prototype.handle_error` of `router` (used by `express.Router`) only handles arity 4
- Linting: As per latest eslint config - Linting: Add `--report-unused-disable-directives` flag - Linting: Switch to `.eslintrc.js` so can add comments - CI: Add `travis.yml` - Testing: Make `nyc` separate script and add it and `lint` to `test` script - Maintenance: Add `.ncurc.js` config to allow `npm-check-updates` to avoid auto-updating peerDeps. - npm: Update deps. (esm, ws) and devDeps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #137 and #138 . (I can rebase this as needed.)
These are changes related to updating all of
package.jsondeps. and devDeps. to the latest versions (leaving peerDeps though adding testing in Travis for both 4 and 5 alpha Express versions).enginesto Node 10+--report-unused-disable-directivesflag.eslintrc.jsso can add commentstravis.ymlnycseparate script and add it andlinttotestscript.ncurc.jsconfig to allownpm-check-updatesto avoid auto-updating peerDeps.If you haven't, I'd recommend first enabling Travis for PRs and I also recommend enabling LGTM.