Skip to content

Conversation

@markekraus
Copy link
Contributor

Description

  • Fix CBH grammar issue
  • Remove unused $startingline variable
  • Collapsed try/catch to the only line that will have exceptions
  • Moved to early out condition on match count to decrease indentation
  • Moved from Array capture to raw output stream for return objects

Related Issue

erm.... no issue.. forgive me father for I have sinned

Motivation and Context

Code cleanup, reduce nesting, minor nit fixes

How Has This Been Tested?

No... but I assume the test will run for the PR

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fix CBH grammar issue
- Remove unused `$startingline` variable
- Collapsed try/catch to the only line that will have exceptions
- Moved to early out condition on match count to decrease indentation
- Moved from Array capture to raw output stream for return objects

Signed-off-by: Mark Kraus <[email protected]>
Copy link
Owner

@HeyItsGilbert HeyItsGilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Enough!

- Fix try/catch brace error

Signed-off-by: Mark Kraus <[email protected]>
@HeyItsGilbert HeyItsGilbert merged commit 585b3e5 into HeyItsGilbert:main Mar 15, 2025
4 checks passed
@markekraus markekraus deleted the markekraus-patch-1 branch March 15, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants