Skip to content

Conversation

@bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Oct 25, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR introduces the ability to set audit exceptions for the autobump workflow in homebrew/cask. There are some audit failures that are easily remedied, and it should be easier from a maintainability point of view to fix them in a PR with 🟥 CI than having to discover them in the autobump workflow logs.

An alternative could be to collect the exceptions from an environment variable that is set in the workflow, which could make it easier to update the list without having to find it in the homebrew/Brew code. I can update if this is preferable.

Copilot AI review requested due to automatic review settings October 25, 2025 00:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for audit exceptions in the bump-cask-pr command to handle known audit failures during the autobump workflow. When the HOMEBREW_TEST_BOT_AUTOBUMP environment variable is present, the min_os audit check is automatically excluded.

Key Changes:

  • Added audit_exceptions parameter to run_cask_audit method with conditional min_os exception
  • Updated method signature and type annotations to support the new parameter
  • Modified audit command to include --except flag with comma-separated exceptions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

nasrin256

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants