-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
flowdown: update livecheck #234880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flowdown: update livecheck #234880
Conversation
Signed-off-by: Rui Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the livecheck strategy for the FlowDown cask from github_latest to github_releases with an explicit regex pattern for version matching.
Key changes:
- Switches from
github_latesttogithub_releasesstrategy for more precise version detection - Adds a regex pattern to match version numbers with optional "v" prefix
samford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind opening an upstream issue to see if they would be willing to mark unstable releases as "pre-release" going forward, so the "latest" release on GitHub is always a stable version? They marked some releases as "pre-release" in the past, so it's unexpected that they wouldn't do the same for 3.10.7-beta.2.
Co-authored-by: Sam Ford <[email protected]>
that is already done, Lakr233/FlowDown#139 |
|
Ah, thanks! I could have sworn that I checked before asking but maybe I didn't. Any objections to waiting a day or two to see if upstream responds to the issue before we merge this? It would save us the trouble of having to open another PR to revert the |
|
yeah, totally works. |
|
Seems like they're on board with marking unstable versions as "pre-release" going forward and the "latest" release is now a stable 3.10.7 version, so I think we can close this PR (and revisit if this happens again). |
|
Sounds good! |
flowdown: update livecheck