Skip to content

Conversation

@chenrui333
Copy link
Member

flowdown: update livecheck

Copilot AI review requested due to automatic review settings November 2, 2025 20:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the livecheck strategy for the FlowDown cask from github_latest to github_releases with an explicit regex pattern for version matching.

Key changes:

  • Switches from github_latest to github_releases strategy for more precise version detection
  • Adds a regex pattern to match version numbers with optional "v" prefix

@chenrui333 chenrui333 added upstream Issue which needs to be resolved by the upstream project. livecheck Issues or PRs related to livecheck labels Nov 2, 2025
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind opening an upstream issue to see if they would be willing to mark unstable releases as "pre-release" going forward, so the "latest" release on GitHub is always a stable version? They marked some releases as "pre-release" in the past, so it's unexpected that they wouldn't do the same for 3.10.7-beta.2.

@chenrui333
Copy link
Member Author

Would you mind opening an upstream issue to see if they would be willing to mark unstable releases as "pre-release" going forward, so the "latest" release on GitHub is always a stable version?

that is already done, Lakr233/FlowDown#139

@chenrui333 chenrui333 requested a review from samford November 2, 2025 20:58
@samford
Copy link
Member

samford commented Nov 2, 2025

Ah, thanks! I could have sworn that I checked before asking but maybe I didn't.

Any objections to waiting a day or two to see if upstream responds to the issue before we merge this? It would save us the trouble of having to open another PR to revert the livecheck block change.

@chenrui333
Copy link
Member Author

yeah, totally works.

@chenrui333 chenrui333 marked this pull request as draft November 2, 2025 22:00
@samford
Copy link
Member

samford commented Nov 3, 2025

Seems like they're on board with marking unstable versions as "pre-release" going forward and the "latest" release is now a stable 3.10.7 version, so I think we can close this PR (and revisit if this happens again).

@samford samford closed this Nov 3, 2025
@chenrui333 chenrui333 deleted the flowdown-livecheck branch November 3, 2025 14:35
@chenrui333
Copy link
Member Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

livecheck Issues or PRs related to livecheck upstream Issue which needs to be resolved by the upstream project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants