Skip to content

Conversation

@chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Oct 26, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

not compatible with kotlin 2.0+

Copilot AI review requested due to automatic review settings October 26, 2025 15:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ki formula to use JDK 21 and marks the formula as deprecated due to incompatibility with Kotlin 2.0+. The changes ensure the formula continues to work with JDK 21 while warning users that the project is unmaintained.

Key Changes:

  • Added deprecation notice with reference to upstream issue
  • Updated dependency from openjdk to openjdk@21
  • Modified all Java-related configuration to use JDK 21 specifically

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added java Java use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Oct 26, 2025
@chenrui333 chenrui333 mentioned this pull request Oct 26, 2025
6 tasks
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 26, 2025
@BrewTestBot BrewTestBot enabled auto-merge October 26, 2025 15:21
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 26, 2025
Merged via the queue into main with commit f27369b Oct 26, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the ki-openjdk21 branch October 26, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. formula deprecated Formula deprecated java Java use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants