Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Oct 26, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Oct 26, 2025
@Copilot Copilot AI review requested due to automatic review settings October 26, 2025 21:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the spidermonkey formula to use Python 3.14 instead of Python 3.13 as a build dependency. To support this change, a patch is added to backport Python 3.14 compatibility from the upstream firefox repository.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Oct 26, 2025
@chenrui333 chenrui333 enabled auto-merge October 26, 2025 21:40
@chenrui333 chenrui333 added this pull request to the merge queue Oct 26, 2025
Merged via the queue into main with commit 7d74150 Oct 26, 2025
39 checks passed
@chenrui333 chenrui333 deleted the spidermonkey-py314 branch October 26, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-bottles Merge without publishing bottles icu4c ICU use is a significant feature of the PR or issue python-3.14-migration rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants