e*: use PyPI DSL #251393
Merged
e*: use PyPI DSL #251393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botantony
added
the
CI-syntax-only
github-actions
bot
added
the
automerge-skip
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates several Python formulas to use the new PyPI DSL (pypi_packages) instead of maintaining package exclusions and customizations in the separate pypi_formula_mappings.json file. This change moves the PyPI package configuration directly into the formula files where it's more maintainable and visible.
Key Changes:
- Removed 6 formula entries from
pypi_formula_mappings.json - Added corresponding
pypi_packagesDSL calls to each affected formula file
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pypi_formula_mappings.json | Removed entries for ecs-deploy, enex2notion, eralchemy, esphome, esptool, and evernote-backup |
| Formula/e/evernote-backup.rb | Added pypi_packages DSL with certifi exclusion |
| Formula/e/esptool.rb | Added pypi_packages DSL with cryptography exclusion |
| Formula/e/esphome.rb | Added pypi_packages DSL with multiple package exclusions |
| Formula/e/eralchemy.rb | Added pypi_packages DSL with custom package name |
| Formula/e/enex2notion.rb | Added pypi_packages DSL with certifi and pymupdf exclusions |
| Formula/e/ecs-deploy.rb | Added pypi_packages DSL with certifi exclusion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
botantony
force-pushed
the
e-pypi-dsl
branch
3 times, most recently
from
9d97edc to
0405c82
Compare
chenrui333
approved these changes
Oct 28, 2025
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
Signed-off-by: botantony <[email protected]>
chenrui333
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?