Support for MH_FILESET

[rickmark]

The macOS 11/12 system uses a new scheme of KextCollections (BootKernelCollection, AuxiliaryKernelCollection, etc). These are created as MH_FILESET objects. This PR completes support for MH_FILESET and its related load commands

[rickmark]

Drat, copy pasta’d the implementation- will fixup Get Outlook for iOS<https://aka.ms/o0ukef>

________________________________ From: William Woodruff ***@***.***> Sent: Tuesday, January 11, 2022 12:06:32 PM To: Homebrew/ruby-macho ***@***.***> Cc: Rick Mark ***@***.***>; Author ***@***.***> Subject: Re: [Homebrew/ruby-macho] Support for MH_FILESET (PR #425) @woodruffw commented on this pull request.

________________________________ In lib/macho/load_commands.rb<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHomebrew%2Fruby-macho%2Fpull%2F425%23discussion_r782488070&data=04%7C01%7C%7C461979b1089449fda78308d9d53ddd42%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637775283946294024%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=UzawQfBfifVB6e%2B15VCZbqCIwfKQlEPiHsLsqleSdGg%3D&reserved=0>:

@@ -1820,6 +1820,24 @@ class FilesetEntryCommand < LoadCommand

# @see MachOStructure::SIZEOF # @api private SIZEOF = 20 + + def initialize(view, cmd, cmdsize, vmaddr, fileoff, entry_id, reserved) + super(view, cmd, cmdsize) + @vmaddr = vmaddr + @fileoff = fileoff + @entry_id = entry_id + @reserved = reserved + end + + # @return [Hash] a hash representation of this {NoteCommand} Nit: {NoteCommand} should be {FilesetEntryCommand}, I think. — Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHomebrew%2Fruby-macho%2Fpull%2F425%23pullrequestreview-849674336&data=04%7C01%7C%7C461979b1089449fda78308d9d53ddd42%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637775283946304022%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=47fQmt3KoMS2NjzBbNiY6yKVJ9n2JzFThGeR8UmlSiM%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAA6TWZTJHZ3UMEU375PONTUVSEURANCNFSM5LWXWC4A&data=04%7C01%7C%7C461979b1089449fda78308d9d53ddd42%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637775283946314017%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=aI7ViTPRrPP%2BjNLZpIHp7YANfSTkEAzJEfQ0g62iD10%3D&reserved=0>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[woodruffw]

One small nit, otherwise looks great! Thanks a ton for rounding the implementation out and for adding a test.

[woodruffw]

Thanks again!

[rickmark]

Sure thing - I know its a nescience but whenever you bump a release I'll be able to depend on this as a gem 🙃

Building a jtool2 clone in ruby and doing .kc analysis (https://github.com/hack-different/apple-knowledge)

[woodruffw]

Sure thing - I know its a nescience but whenever you bump a release I'll be able to depend on this as a gem 🙃

Not a nuisance at all! I'm going to merge #424 tonight and cut a new major release with those changes as well.

[rickmark]

Wow spelling lol, yeah I’m about to go brag about how ruby is better because you can get a fix upstream this fast unlike python Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: William Woodruff ***@***.***> Sent: Tuesday, January 11, 2022 1:12:52 PM To: Homebrew/ruby-macho ***@***.***> Cc: Rick Mark ***@***.***>; Author ***@***.***> Subject: Re: [Homebrew/ruby-macho] Support for MH_FILESET (PR #425) Sure thing - I know its a nescience but whenever you bump a release I'll be able to depend on this as a gem 🙃 Not a nuisance at all! I'm going to merge #424<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHomebrew%2Fruby-macho%2Fpull%2F424&data=04%7C01%7C%7C08a9d48aaf0948f7d4de08d9d54721e0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637775323762373279%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=lpFWessf7NEqInjOa9jd3frkVFsbLp5mZ1uG5S5nEHs%3D&reserved=0> tonight and cut a new major release with those changes as well. — Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHomebrew%2Fruby-macho%2Fpull%2F425%23issuecomment-1010363477&data=04%7C01%7C%7C08a9d48aaf0948f7d4de08d9d54721e0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637775323762378283%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5PcS9nNnsbKFL1Pli576mPGdeT4akfym6VM%2Bqhbs7fg%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAA6TWZ4YYNEERD7AIXIV53UVSMNJANCNFSM5LWXWC4A&data=04%7C01%7C%7C08a9d48aaf0948f7d4de08d9d54721e0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637775323762388277%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=QaBJEbLAYIFgtepsi5BlAMTMEmCKjmgZ6OO8YtXyChY%3D&reserved=0>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[woodruffw]

Okay, I've cut these changes with 3.0.0. Let me know if you run into any problems!