Use built-in tar instead of 7zip on windows. #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the implied 7zip dependency in favour of using
tarwhich has been available by default on Windows for a while now, as noted in #883 (See https://techcommunity.microsoft.com/blog/containers/tar-and-curl-come-to-windows/382409).I needed to change this for my own use, so decided to contribute, hopefully this is acceptable. Imho, requiring windows versions released after 2017/18 is better than requiring 7zip. Alternatively, this can be reworked to try to find both
7zipandtarand decide which one to use, but imo that's overkill considering this is supposed to be replaced by the stdlib implementation (any time now, Apple...)