Skip to content

fix: wording while deleting draft dataset #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: wording while deleting draft dataset #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/locales/en/dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
},
"deleteDatasetModal": {
"title": "Delete Dataset",
"message": "Are you sure you want to delete this dataset? This action cannot be undone.",
"message": "Are you sure you want to delete this draft version? Files will be reverted to the most recently published version. You cannot undelete this draft.",
"defaultDatasetDeleteError": "An error occurred while deleting the dataset."
}
},
Expand Down Expand Up @@ -137,7 +137,7 @@
"heading": "Unpublished Dataset Private URL",
"alertText": "This unpublished dataset is being privately shared."
},
"datasetDeletedSuccess": "The dataset has been deleted."
"datasetDeletedSuccess": "The dataset draft has been deleted."
},
"termsTab": {
"editTermsButton": "Edit Term Requirements",
Expand Down
4 changes: 2 additions & 2 deletions ...ctions/dataset/dataset-action-buttons/edit-dataset-menu/DeleteDraftDatasetButton.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ describe('DeleteDraftDatasetButton', () => {
cy.findByRole('button', { name: 'Delete Dataset' }).click()

cy.findByRole('dialog').should('exist')
cy.findByText(/Are you sure you want to delete this dataset?/i).should('exist')
cy.findByText(/Are you sure you want to delete this draft version?/i).should('exist')
})

it('closes confirmation modal when cancel is clicked', () => {
Expand Down Expand Up @@ -118,7 +118,7 @@ describe('DeleteDraftDatasetButton', () => {
cy.findByRole('dialog').should('exist')
cy.findByRole('button', { name: 'Delete' }).click()
cy.findByRole('dialog').should('not.exist')
cy.findByText(/The dataset has been deleted./).should('exist')
cy.findByText(/The dataset draft has been deleted./).should('exist')
})

it('should not delete dataset if delete button clicked and repository fails', () => {
Expand Down
4 changes: 2 additions & 2 deletions ...ponent/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,9 @@ describe('EditDatasetMenu', () => {
)
cy.findByRole('button', { name: 'Edit Dataset' }).click()
cy.findByRole('button', { name: /Delete/ }).click()
cy.findByText(/Are you sure you want to delete this dataset?/i).should('exist')
cy.findByText(/Are you sure you want to delete this draft version?/i).should('exist')
cy.findByRole('button', { name: 'Delete' }).click()
cy.findByText(/The dataset has been deleted./).should('exist')
cy.findByText(/The dataset draft has been deleted./).should('exist')

const searchParams = new URLSearchParams({
[QueryParamKey.PERSISTENT_ID]: dataset.persistentId,
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e-integration/e2e/sections/dataset/Dataset.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,9 @@ describe('Dataset', () => {

cy.findByRole('button', { name: 'Edit Dataset' }).should('exist').click()
cy.findByRole('button', { name: 'Delete Dataset' }).should('exist').click()
cy.findByText(/Are you sure you want to delete this dataset?/i).should('exist')
cy.findByText(/Are you sure you want to delete this draft version?/i).should('exist')
cy.findByRole('button', { name: 'Delete' }).should('exist').click()
cy.findByText(/The dataset has been deleted./i).should('exist')
cy.findByText(/The dataset draft has been deleted./i).should('exist')
})
})
})
Expand Down
Loading