🎨♻️ cosmetic / refactor: remove default value #8660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnicegyu11
added
t:maintenance
mrnicegyu11
requested review from
GitHK,
pcrespov and
sanderegg
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #8660 +/- ##
===========================================
- Coverage 87.55% 68.46% -19.09%
===========================================
Files 2019 782 -1237
Lines 79254 35552 -43702
Branches 1386 154 -1232
===========================================
- Hits 69393 24342 -45051
- Misses 9465 11161 +1696
+ Partials 396 49 -347
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for ef2ee70. 🟢 All jobs passed!But CI Insights is watching 👀 |
pcrespov
approved these changes
Dec 2, 2025
GitHK
reviewed
Dec 3, 2025
Contributor
GitHK
left a comment
GitHK
left a comment
There was a problem hiding this comment.
Please make sure to also check that all tests are greeen, then I will have a look at it again to see if other things break
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_task.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_abc.py
Show resolved
Hide resolved
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I found this by chance while checking some things for the trace-propagation in dv2 (this PR is unrelated to tracing). There is the param
skip_observation_recreationwhich is boolean, and has impact on the behavior of dv2 dy service schedulingBefore, the param would be implicitly
Falseby default, except for 1 case where it is overwritten to True (here https://github.com/mrnicegyu11/osparc-simcore/blob/ae88c2af1a5b4cb52f383ce6117718a1e1cfd522/services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_observer.py#L60 ).Now, for the few occurances of it, the param is always passed explicitly. This makes the behaviour more understandable when reading code.
A very minor change that I suggest, without impact on the behavior :--)
Related issue/s
How to test
Dev-ops