Skip to content

Conversation

@mrnicegyu11
Copy link
Member

What do these changes do?

Related issue/s

How to test

Dev-ops

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.89%. Comparing base (eba3614) to head (6ae090e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8661      +/-   ##
==========================================
- Coverage   87.20%   85.89%   -1.32%     
==========================================
  Files        1933     1576     -357     
  Lines       76541    65808   -10733     
  Branches     1386      670     -716     
==========================================
- Hits        66749    56526   -10223     
+ Misses       9396     9056     -340     
+ Partials      396      226     -170     
Flag Coverage Δ *Carryforward flag
integrationtests 63.90% <ø> (+0.06%) ⬆️ Carriedforward from 93e1abb
unittests 86.04% <ø> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.36% <ø> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.51% <ø> (+0.06%) ⬆️
agent 93.44% <ø> (ø)
api_server 91.37% <ø> (ø)
autoscaling 95.70% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 91.72% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.81% <ø> (+0.08%) ⬆️
director_v2 78.55% <ø> (-12.57%) ⬇️
dynamic_scheduler 96.66% <ø> (∅)
dynamic_sidecar 90.82% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.70% <ø> (ø)
resource_usage_tracker 92.06% <ø> (-0.11%) ⬇️
storage 86.74% <ø> (+0.11%) ⬆️
webclient ∅ <ø> (∅)
webserver 86.67% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba3614...6ae090e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025

🧪 CI Insights

Here's what we observed from your CI run for 6ae090e.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI build-test-images (frontend) / build-test-images Healthy 0 View View
unit-tests Healthy 0 View View
PR CI check OAS' are up to date Unknown 0 View View

request_scheme=request_scheme,
request_simcore_user_agent=request_simcore_user_agent,
can_save=can_save,
can_save=can_save, # meepmoop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to the best of my memory meepmoop means here we need to parse or pass tracingcontext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant