Skip to content

Fix TypeError in IgxTextHighlightDirective when destroyed before initialization #16456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix TypeError in IgxTextHighlightDirective when destroyed before initialization #16456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f999d3d
Initial plan
Copilot Nov 13, 2025
deec2b8
Add null checks to prevent TypeError in IgxTextHighlightDirective lif…
Copilot Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions projects/igniteui-angular/src/lib/directives/text-highlight/text-highlight.directive.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,24 @@ describe('IgxHighlight', () => {

expect(() => component.highlight.activateIfNecessary()).not.toThrowError();
});

it('Should not throw error when destroyed before ngAfterViewInit completes', () => {
const fix = TestBed.createComponent(HighlightLoremIpsumComponent);
// Do not call detectChanges() - this simulates destruction before ngAfterViewInit

// Destroy the component before initialization completes
expect(() => fix.destroy()).not.toThrowError();
});

it('Should return 0 when highlight is called before ngAfterViewInit completes', () => {
const fix = TestBed.createComponent(HighlightLoremIpsumComponent);
const component: HighlightLoremIpsumComponent = fix.debugElement.componentInstance;

// Call highlight before detectChanges (before ngAfterViewInit)
const count = component.highlight.highlight('test', false, false);

expect(count).toBe(0);
});
});

@Component({
Expand Down
16 changes: 13 additions & 3 deletions projects/igniteui-angular/src/lib/directives/text-highlight/text-highlight.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export class IgxTextHighlightDirective implements AfterViewInit, AfterViewChecke
* @hidden
*/
public ngAfterViewChecked() {
if (this._valueChanged) {
if (this._valueChanged && this._lastSearchInfo) {
this.highlight(this._lastSearchInfo.searchText, this._lastSearchInfo.caseSensitive, this._lastSearchInfo.exactMatch);
this.activateIfNecessary();
this._valueChanged = false;
Expand All @@ -278,6 +278,10 @@ export class IgxTextHighlightDirective implements AfterViewInit, AfterViewChecke
* Returns how many times the element contains the searched text.
*/
public highlight(text: string, caseSensitive?: boolean, exactMatch?: boolean): number {
if (!this._lastSearchInfo) {
return 0;
}

const caseSensitiveResolved = caseSensitive ? true : false;
const exactMatchResolved = exactMatch ? true : false;

Expand Down Expand Up @@ -308,8 +312,10 @@ export class IgxTextHighlightDirective implements AfterViewInit, AfterViewChecke
public clearHighlight(): void {
this.clearChildElements(false);

this._lastSearchInfo.searchText = '';
this._lastSearchInfo.matchCount = 0;
if (this._lastSearchInfo) {
this._lastSearchInfo.searchText = '';
this._lastSearchInfo.matchCount = 0;
}
}

/**
Expand Down Expand Up @@ -469,6 +475,10 @@ export class IgxTextHighlightDirective implements AfterViewInit, AfterViewChecke
}

private searchNeedsEvaluation(text: string, caseSensitive: boolean, exactMatch: boolean): boolean {
if (!this._lastSearchInfo) {
return false;
}

const searchedText = this._lastSearchInfo.searchText;

return !this._nodeWasRemoved &&
Expand Down
Loading