feat: add platine management export permission check#386
feat: add platine management export permission check#386
Conversation
davdarras
commented
Jan 16, 2026
davdarras
commented
- check permission
- add compose
- check permission - add compose
davdarras
requested review from
Hajarel-moukh,
alexisszmundy and
loichenninger
| import java.nio.charset.StandardCharsets; | ||
|
|
||
| @Slf4j | ||
| public class LoggingInterceptor implements ClientHttpRequestInterceptor { |
There was a problem hiding this comment.
No conflict with fr.insee.genesis.configuration.LogRequestFilter ?
There was a problem hiding this comment.
should not have conflict, 2 different purposes:
- LogRequestFilter => log user requests on genesis api
- LoggingInterceptor => log the requests/responses when genesis api calls platine-management api
|
|
||
|
|
||
| @Bean("platineRestClientBuilder") | ||
| public RestClient.Builder platineRestClientBuilder() { |
There was a problem hiding this comment.
we used webclient in fr.insee.genesis.infrastructure.utils.http.HttpUtils
Maybe we have to harmonize
There was a problem hiding this comment.
I had a little chat with @loichenninger on this specific subject. WebClient should not be used anymore for this kind of cases. Its primary usage is to send asynchron requests. Here, WebClient is used to make synchrone calls (.block()). In recent versions of spring:
- synchron => RestClient
- asynchron => WebClient
There was a problem hiding this comment.
@loichenninger proposed to harmonize this in a next feature
There was a problem hiding this comment.
Ok, something to do for us in the next 3 weeks ;-)
3 participants
