Use qualified name instead of package + simple name for module def #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArchdukeTim
force-pushed
the
parentNameInClassDef
branch
from
56af52b to
efefddd
Compare
ArchdukeTim
force-pushed
the
parentNameInClassDef
branch
from
efefddd to
a077265
Compare
Author
|
@arnaudgiuliani I tried installing and running the tests, but it seems that my ksp generator is still using some version of the code that doesn't have my changes? |
andrewcaplan1
approved these changes
Aug 13, 2025
andrewcaplan1
left a comment
andrewcaplan1
left a comment
There was a problem hiding this comment.
Looks great! Happy to see this fix.
ArchdukeTim
force-pushed
the
parentNameInClassDef
branch
from
a077265 to
e9472c1
Compare
Member
did you test again 2.1.1-RC1 or even 2.2.0-RC1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #297 only looks one parent up. This will get the full path regardless of nested layers.
Since the only place the class name was used was in the prefix, I thought it best to just remove the manual concatenation
and just used the qualified name