map & set multibinding

[luozejiaqun]

Implement map & set multibinding just like dagger2.
Here is some implementation details:

Every MapMultibinding & SetMultibinding will involve 3 definitions:

1. the multibinding itself whose qualifier is mapMultibindingQualifier or setMultibindingQualifier
2. the element in multibinding whose qualifier is multibindingElementQualifier (use mapMultibindingQualifier/setMultibindingQualifier as prefix)
3. the MultibindingIterateKey which used to retrieve all elements, the key's qualifier is multibindingIterateKeyQualifier (also use mapMultibindingQualifier/setMultibindingQualifier as prefix)

When getting specific element from map multibinding, the map multibinding will try to retrieve the element through multibindingValueQualifier;
When getting all elements from map or set multibinding, the multibinding will first try to get all MultibindingIterateKeys and filter them based on multibindingQualifier, and then retrieve each element through multibindingElementQualifier.

The known problems:

1. the multibinding qualifier can't be null, since it's qualifier will be used as prefix of element & iterate key
2. the map multibinding doesn't support null as a key or value
3. the elements order of multibiding is different with the order of element definitions Now, both set & map multibinding elements are iterated in the order they are defined.

And just like dagger2, multibinding is inherited (because MultibindingIterateKey can be retrieved from getAll), current scope's multibinding can get all elements that define in linked scope.

Here are some use cases:

module {
    intoMap<String, Simple.ComponentInterface1>("keyOfComponent1") {
        Simple.Component1()
    }
    intoMap<String, Simple.ComponentInterface1>("keyOfComponent2") {
        Simple.Component2()
    }

    intoSet<Simple.ComponentInterface1> {
        Simple.Component1()
    }
    intoSet<Simple.ComponentInterface1> {
        Simple.Component2()
    }
}

val map: Map<String, Simple.ComponentInterface1> = koin.getMapMultibinding()
val set: Set<Simple.ComponentInterface1> = koin.getSetMultibinding()

issue #772

[arnaudgiuliani]

Looks interesting, will check for 4.1 👍

[luozejiaqun]

UPDATE:
the old implement is too error prone to write the following code:

module {
    intoMap("keyOfComponent1") {
        Simple.Component1() // implicitly declare Map<String, Simple.Component1>
    }
    intoMap("keyOfComponent2") {
        Simple.Component2() // implicitly declare Map<String, Simple.Component2>
    }

    intoSet {
        Simple.Component1() // implicitly declare Set<Simple.Component1>
    }
    intoSet {
        Simple.Component2() // implicitly declare Set<Simple.Component2>
    }
    /* Map<String, Simple.Component1> & Map<String, Simple.Component2>,
    Set<Simple.Component1> & Set<Simple.Component2> are different multibindings */
}

so I update the implement. Now elements can only be injected through explicit multibinding declaration and force type safety:

module {
    declareMapMultibinding<String, Simple.ComponentInterface1> {
        intoMap("keyOfComponent1") { Simple.Component1() }
        intoMap("keyOfComponent2") { Simple.Component2() }
        intoMap("keyOfComponent3") { Other() } // build error
    }

    declareSetMultibinding<Simple.ComponentInterface1> {
        intoSet { Simple.Component1() }
        intoSet { Simple.Component2() }
        intoSet { Other() } // build error
    }
}

[luozejiaqun]

The rare use cases:

data class MapKey(
    val name: String,
    val value: Int,
) {
    override fun toString(): String = name
}

module {
    declareMapMultibinding<MapKey, Simple.ComponentInterface1> {
        intoMap(MapKey("key", 1)) { Simple.Component1() }
        intoMap(MapKey("key", 2)) { Simple.Component1() }
    }
}

UPDATE: this problem has solved, the map contains two elements.

[luozejiaqun]

The multibinding overrides issue:

module {
    declareMapMultibinding<String, Simple.ComponentInterface1> {
        intoMap("keyOfComponent1") { Simple.Component1() }
    }
}

module {
    declareMapMultibinding<String, Simple.ComponentInterface1> { // multibinding overrides
        intoMap("keyOfComponent2") { Simple.Component2() }
    }
}

Generally, you can declare elements across modules, but here, multibinding overloads actually occur. However, these multiple multibinding declarations are essentially the same.
But what if we load modules with allowOverride = false, here is the question: Are multibinding overloads considered overloads? If they are, then the current implementation is fine (but the messages of DefinitionOverrideException maybe a little unreadable). If not, then we need to exclude these cases during loadModules. But how to detect and exclude them? I lean towards the former, that is, in this scenario, you must declare multibinding and inject all elements within the same module.

[luozejiaqun]

An explanation of elements order with example:

val module2 = module {
    scope(scopeKey) {
        declareMapMultibinding<Int, Simple.ComponentInterface1> {
            intoMap(2) { Simple.Component1() }
        }
    }
}
val module1 = module {
    scope(scopeKey) {
        declareMapMultibinding<Int, Simple.ComponentInterface1> {
            intoMap(1) { Simple.Component1() }
        }
    }
}

val module4 = module {
    declareMapMultibinding<Int, Simple.ComponentInterface1> {
        intoMap(4) { Simple.Component1() }
    }
}
val module3 = module {
    declareMapMultibinding<Int, Simple.ComponentInterface1> {
        intoMap(3) { Simple.Component1() }
    }
}

startKoin {
    modules(module1, module2, module3, module4)
}

val map: Map<Int, Simple.ComponentInterface1> = scope.getMapMultibinding()
// in elements definition order, but linked scope (root scope) elements first then current scope elements
// module definition order is irrelevant, but module loading order is key.
map.keys.toList() == listOf(3, 4, 1, 2)

It's not that I intentionally maintain the order, but this order is crucial for element overloading. For example:

val component = Simple.Component1()
val module44 = module {
    declareMapMultibinding<Int, Simple.ComponentInterface1> {
        intoMap(4) { component }
    }
}

modules(module1, module2, module3, module4, module44)

map[4] === component // later element definition wins

[arnaudgiuliani]

@luozejiaqun it's a great proposal, I would like to review naming/API to propose something more compact.

I opened KFIP https://github.com/InsertKoinIO/KFIP/ to open design process to public. This could be a good first proposal that we can design together. I can start a draft and we can work together on this Map/Set injection feature.

We can talk also on #koin-contributors channel

[luozejiaqun]

@arnaudgiuliani I'm looking forward to talking more about this with you, and I do have a few questions. I tried making a PR on KFIP, but writing so much English technical documentation is a little difficult for me.

[arnaudgiuliani]

Let me bootstrap it, this should frame our discussion around 👍

[arnaudgiuliani]

I'm looking at external contributions next week 👍

[arnaudgiuliani]

Hey @luozejiaqun, really sorry for the timing :/

Are you still interested in working together on this feature? I believe we can do some good Dev Ex design here ?

[luozejiaqun]

@arnaudgiuliani sure

[arnaudgiuliani]

ok cool 👍

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dees91]

Why was this PR closed? It looked very promising, and honestly, I was really looking forward to this functionality...

[arnaudgiuliani]

closed branch, sorry

[ksharma-xyz]

any updates on this. @arnaudgiuliani