[koin-android] Remove transitive dependency for appcompat library #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorikftp
commented
Aug 23, 2025
egorikftp
commented
- closes: [koin-android] Remove transitive dependency for appcompat library #2272
egorikftp
changed the title
egorikftp
force-pushed
the
feature/remove-transitive-appcompat-library
branch
from
61ac568 to
bfa5f1c
Compare
Author
|
Something wrong with maven 😪 |
Member
|
I keep it for Koin 4.2, avoiding to impact structure for now |
There was a problem hiding this comment.
Pull request overview
This pull request removes the transitive dependency on the androidx.appcompat library from the koin-android module by replacing AppCompatActivity with ComponentActivity throughout the codebase. This change reduces the dependency footprint while maintaining the necessary functionality for Android scope management.
Key Changes
- Removed the
android-appcompatdependency from both the version catalog and build configuration - Replaced
AppCompatActivitywithComponentActivityas the base class forScopeActivityandRetainedScopeActivity - Updated documentation comments to reflect the change from AppCompatActivity to ComponentActivity
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
projects/gradle/libs.versions.toml |
Removed android-appcompat version variable and library definition |
projects/android/koin-android/build.gradle.kts |
Removed api dependency on android-appcompat library |
projects/android/koin-android/src/main/java/org/koin/androidx/scope/ScopeActivity.kt |
Changed base class from AppCompatActivity to ComponentActivity and updated KDoc |
projects/android/koin-android/src/main/java/org/koin/androidx/scope/RetainedScopeActivity.kt |
Changed base class from AppCompatActivity to ComponentActivity, removed unused TypeQualifier import, and updated KDoc |
projects/android/koin-android/src/main/java/org/koin/androidx/scope/ComponentActivityExt.kt |
Updated documentation comments to reference ComponentActivity instead of AppCompatActivity |
projects/android/koin-android/src/main/java/org/koin/androidx/scope/AndroidScopeArchetypes.kt |
Updated ActivityScopeArchetype to use ComponentActivity::class instead of AppCompatActivity::class |
README.md |
Updated Kotlin version badge (contains incorrect version) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.