Skip to content

Fix premature release of scope & context #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnaudgiuliani merged 1 commit into from
Dec 5, 2025
+7 −3
Merged

Fix premature release of scope & context #2326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...se/src/commonMain/kotlin/org/koin/compose/application/CompositionKoinApplicationLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ class CompositionKoinApplicationLoader(
}

override fun onAbandoned() {
koin?.logger?.warn("CompositionKoinApplicationLoader - onAbandoned")
stop()
}

override fun onForgotten() {
stop()
koin?.logger?.debug("CompositionKoinApplicationLoader - onForgotten")
//don"t stop here, premature
}

override fun onRemembered() {
Expand All @@ -46,8 +48,8 @@ class CompositionKoinApplicationLoader(
}

private fun stop() {
koin?.logger?.warn("CompositionKoinApplicationLoader - stop")
koin = null
KoinPlatform.getKoinOrNull()?.logger?.debug("$this -> stop Koin Application $koinApplication")
stopKoin()
}
}
4 changes: 3 additions & 1 deletion ...e/koin-compose/src/commonMain/kotlin/org/koin/compose/scope/CompositionKoinScopeLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,12 @@ class CompositionKoinScopeLoader(
}

override fun onForgotten() {
close()
scope.logger.debug("CompositionKoinScopeLoader onForgotten: '${scope.id}'")
//don"t stop here, premature
}

override fun onAbandoned() {
scope.logger.debug("CompositionKoinScopeLoader onAbandoned: '${scope.id}'")
close()
}

Expand Down
Loading