-
Notifications
You must be signed in to change notification settings - Fork 38
Add building wheel packages #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ccf2f94 to
321f593
Compare
321f593 to
eaefa35
Compare
6164a16 to
8eb354d
Compare
Yep, it was my initial intention also, but I rolled back these changes. And I would prefer to keep that to follow-up PRs, it hasn't block the releasing of the fix. The real issue here is the tag format. Current approach assume something like |
|
@ndgrigorian, @vtavana please review |
vtavana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @antonwolfy!
The issue IntelPython/dpnp#2505 is resolved when using the wheel artifact created in the CI of this PR.
After downloading the artifact mkl_service-2.5.1-cp310-cp310-manylinux_2_28_x86_64.whl and moving it to a directory named whl.
python3 -m venv test
source test/bin/activate
pip install --no-cache-dir -i https://software.repos.intel.com/python/pypi numpy --find-links ./whl/
one can import numpy without any issues.
This PR extends build scripts to enable building of wheel packages.
The changes are based on the internal scripts used by the Infrastructure team to build
mkl-servicewheel packages.The main difference is to use
wheel tagscommand instead ofauditwheel repairone which might broke loading of MKL libs.That may happen because
auditwheel repaircreates isolatedlib/python3.x/site-packages/mkl_service.libsfolder with onlylibmkl_rt-*.so.2lib included and there is no rpath set to a folder with all other MKL libs require for proper loading.Additionally, the PR adds explicit specifies runtime library directories towards expecting MKL libs folder in the virtual env to have this working out of the box there.
Also, the GitHub workflow
Conda packageis proposing to be extended to upload the wheel packages.