Skip to content

Conversation

@menvae
Copy link
Contributor

@menvae menvae commented Aug 8, 2025

{02DBCFAB-B11B-4FB0-A91A-8FCD08D65343}

Clipboard

{61513710-CA0A-41DA-9496-9918E19DE09C}

Navbar + back button

Changes

  • Add "copy to clipboard" button to codeblocks
  • Add url bar
  • Add back button

@flustix
Copy link
Member

flustix commented Aug 17, 2025

The sizing for the navigation is way too big and the hover doesn't match web. Additionally the titles should be formatted properly (perhaps Humanizer could be used for this).

Also why is the clipboard button based off ToolbarButton? That button is supposed to only be used for the toolbar, as the name implies.

@menvae
Copy link
Contributor Author

menvae commented Aug 17, 2025

The sizing for the navigation is way too big and the hover doesn't match web

Aware of this, the Map browser itself doesn't match the web 1:1 either, and having the hover highlight the background looks way more consistent with the game's styling.

Additionally the titles should be formatted properly (perhaps Humanizer could be used for this).

Could you give examples on how they look incorrectly formatted?

Also why is the clipboard button based off ToolbarButton? That button is supposed to only be used for the toolbar, as the name implies.

Because ToolbarButton already had the needed functionality unless there is some button with the same styling and functionality that I'm not aware of and you also had problems with creating new classes instead of reusing already existing ones.

@flustix
Copy link
Member

flustix commented Aug 25, 2025

  • The navigation is still not matching web. (and no, the general design does NOT work well here, they are not usual buttons)
  • The scaling of the buttons moves everything in the navigation around.

Basically:
Make it match web.

@menvae
Copy link
Contributor Author

menvae commented Aug 26, 2025

Keep BackButton the same or change it to match path button?

@flustix
Copy link
Member

flustix commented Aug 26, 2025

The back button acts more like a button so the design is fine.
I would just adjust its sizing for not be way bigger than the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants