Optimization references loader #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Serilog for improved debugging in CsProject.cs. - Optimized project reference handling to reduce redundancy. - Introduced precompiled regex for faster target framework evaluations. - Updated fallback target framework to "net9.0". - Enhanced logging in ElementConditionPasses for better traceability. - Improved Evaluate method for expanded conditions handling. - Updated launchSettings.json for verbosity and corrected paths.
Refactored the code to replace nested loops for iterating over target frameworks with a single assignment that selects the first target framework. This simplification reduces iterations and conditions checked. Additionally, adjusted condition checks for `PackageReference` elements to ensure correct evaluation based on the new structure, enhancing code clarity and efficiency.
Modified the test to assert that "PkgOnlyNet9" is not included in the references, reflecting a focus on a single target framework. The previous assertion for its presence has been commented out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several optimizations and improvements to the references loader in the AX# project. The main changes include:
CsProject.csto handle target frameworks more effectively, reducing complexity and potential errors.