[BUG] Bulk write method may write ro members #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Filter writable primitives in WriteBatchAsync method. - Update expected Apax version from 3.5.0 to 4.0.0. - Change build command in delta and full download scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to improve compatibility with the latest tools and ensure correct write operations in the WebAPI connector. The most significant changes are grouped below:
Tooling and Script Updates:
apaxversion to4.0.0incheck_requisites_apax.shto ensure compatibility with the latest tooling.--ignore-scriptsflag from theapax buildcommand in bothsw_build_and_download_delta.shandsw_build_and_download_full.sh, allowing build scripts to run as intended during the build process. [1] [2]WebAPI Connector Logic:
WriteBatchAsyncinWebApiConnector.csto filter primitives so that only those withReadWriteAccess.ReadWriteare processed for writing, preventing unintended write attempts to read-only primitives.closes #438