[feat] Split checking reading and assingin identities #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated WebApiConnector to include logging for connection attempts and introduced a new HTTP client. Refactored TwinIdentityProvider to implement flexible identity assignment with new methods for assigning and writing identities. Added DuplicateIdentityException for improved error handling during identity sorting.
PTKu
deleted the
447-feat-split-checking-reading-and-assingin-identities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to logging for connection attempts and identity management, and refactors how identities are assigned and written in the
TwinIdentityProviderclass. It also adds error handling for duplicate identities to ensure uniqueness and robustness in identity assignment.Logging Enhancements
WebApiConnectorconstructor, improving traceability of connection operations. [1] [2]Identity Management Refactoring
TwinIdentityProviderby extracting it into a new methodAssignIdentities, allowing for customizable identity assignment algorithms and improving code clarity.WriteIdentitiesto handle writing identities to the PLC, separating concerns and making the workflow more explicit.ConstructIdentitiesAsyncto support custom identity assignment algorithms via an optional parameter, increasing flexibility.Error Handling
DuplicateIdentityExceptionthat is thrown when duplicate identities are detected during sorting, ensuring that assigned identities are unique and providing a clear error message for debugging.Minor Code Improvements
WebApiConnectorfor readability.closes #447