Fix a Crash: check for invalid square at isAttackedBy() (bitboard.h) #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit Fixes the following crash scenario: In Menus: Click Edit | Setup Position... Click Clear Click on White King CRASH This commit checks in advance for InvalidSquare in function is AttackedBy(). The crash was: If a King is removed its square is set to InvalidSquare, Later when checking if that square is attacked we have a crash of accessing index beyond the board size.
bdeyal
changed the title
Contributor
Author
|
@Isarhamster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit Fixes the following crash scenario:
In Menus:
Click Edit | Setup Position...
Click Clear
Click on White King
CRASH
This commit checks in advance for InvalidSquare in function is AttackedBy().
The crash was: If a King is removed its square is set to InvalidSquare, Later when checking if that square is attacked we have a crash of accessing index beyond the board size.