feat: support short form teams url #1869

Yumeo0 · 2025-10-10T12:34:54Z

changes the url regex pattern to support the shorter teams url format

gemini-code-assist · 2025-10-10T12:35:05Z

Summary of Changes

Hello @Yumeo0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial update to the application's URL parsing logic, enabling it to correctly recognize and handle the recently introduced shorter URL format for Microsoft Teams meetings. This enhancement ensures seamless integration and improved user experience when interacting with Teams meeting links, adapting to changes in the platform's URL structure.

Highlights

Teams URL Pattern Update: The regular expression used to identify Microsoft Teams meeting URLs has been updated to support a new, shorter URL format (e.g., https://teams.microsoft.com/meet/).
Version Bump: The application version has been incremented from 2.5.13 to 2.5.14 in package.json.
Changelog Entry: A new release entry for version 2.5.14 has been added to the appdata.xml file, documenting the support for short form Teams join URLs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request successfully adds support for the shorter Microsoft Teams URL format by updating the validation regex. The version is bumped to 2.5.14, and the release notes are updated accordingly. The changes are correct and achieve the intended goal. I have one suggestion to improve code style and performance by defining the regular expression as a constant outside the function to avoid recompilation on each call.

app/menus/index.js

IsmaelMartinez · 2025-10-11T07:35:18Z

Hi @Yumeo0 , thanks for the commit. I think we will need to also modify the urls in the config location, otherwise it will not know it has to open the url (I might be wrong and it getting translated).

If you can also run npm i and push the package-lock.json that will be ready, otherwise the release will fail. Thanks again!

Yumeo0 · 2025-10-11T11:34:56Z

@IsmaelMartinez I updated the config to also accept the shortform urls and used that regex instead of the local variable I had before. I also split the config up into "all teams links" and "meeting urls only".

sonarqubecloud · 2025-10-11T11:37:51Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

IsmaelMartinez

Thanks for the hard work. Just re-use the meetupJoinRegEx instead of creating a new one, as otherwise the users that are overwriting this value with the config option will get a change of behaviour (it will stop overwriting the right one). I put some hopefully easy to accept suggestions (that should work but haven't tested). Thanks again!

IsmaelMartinez · 2025-10-12T07:30:03Z

app/config/index.js

+        default: "^https://teams\\.(microsoft|live)\\.com/.*/(?:meetup-join|meet)",
+        describe: "Regex for Teams meetup-join links only",
+        type: "string",
+      },
+
+      allTeamsLinksRegEx: {
+        default: "^https://teams\\.(microsoft|live)\\.com/.*/(?:meetup-join|channel|chat|meet)",
+        describe: "Regex for all Teams-related links (meetup, channel, chat, meet)",


apologies the confusion but just re-use the same RegEx, otherwise people overwriting this local configuration in their config files will see a change in behaviour.

Suggested change

default: "^https://teams\\.(microsoft|live)\\.com/.*/(?:meetup-join|meet)",

describe: "Regex for Teams meetup-join links only",

type: "string",

},

allTeamsLinksRegEx: {

default: "^https://teams\\.(microsoft|live)\\.com/.*/(?:meetup-join|channel|chat|meet)",

describe: "Regex for all Teams-related links (meetup, channel, chat, meet)",

default: "^https://teams\\.(microsoft|live)\\.com/.*/(?:meetup-join|channel|chat|meet)",

describe: "Regex for all Teams-related links (meetup, channel, chat, meet)",

IsmaelMartinez · 2025-10-12T07:30:21Z

app/mainAppWindow/index.js

  for (const arg of args) {
    console.debug(
-      `testing RegExp processArgs ${new RegExp(config.meetupJoinRegEx).test(
+      `testing RegExp processArgs ${new RegExp(config.allTeamsLinksRegEx).test(


Suggested change

`testing RegExp processArgs ${new RegExp(config.allTeamsLinksRegEx).test(

`testing RegExp processArgs ${new RegExp(config.meetupJoinRegEx).test(

IsmaelMartinez · 2025-10-12T07:30:28Z

app/mainAppWindow/index.js

      )}`
    );
-    if (new RegExp(config.meetupJoinRegEx).test(arg)) {
+    if (new RegExp(config.allTeamsLinksRegEx).test(arg)) {


Suggested change

if (new RegExp(config.allTeamsLinksRegEx).test(arg)) {

if (new RegExp(config.meetupJoinRegEx).test(arg)) {

IsmaelMartinez · 2025-10-12T07:30:59Z

docs-site/docs/configuration.md

 | `spellCheckerLanguages` | `array` | `[]` | Array of languages to use with Electron's spell checker |
 | `logConfig` | `object` | `{ transports: { console: { level: "info" }, file: { level: false } } }` | Electron-log configuration |
-| `meetupJoinRegEx` | `string` | `^https://teams.(microsoft\|live).com/.*(?:meetup-join\|channel\|chat)` | Meetup-join and channel regular expression |
+| `allTeamsLinksRegEx` | `string` | `^https://teams\\.(microsoft|live)\\.com/.*/(?:meetup-join|channel|chat|meet)` | All Teams-related links regular expression |


IsmaelMartinez · 2025-11-02T07:52:26Z

done the changes in #1915 as I don't have permission to touch your repo. I did pull your commits so you should get credit for your work. Thanks again for your contribution!

Yumeo0 · 2025-11-05T10:55:58Z

done the changes in #1915 as I don't have permission to touch your repo. I did pull your commits so you should get credit for your work. Thanks again for your contribution!

I kind of forgot to do this as I had a bit of stress the last couple of weeks. Thanks for your work ❤️

IsmaelMartinez · 2025-11-06T16:37:46Z

no problem and thanks for your work/help!

feat: support short form teams url

e5fc816

gemini-code-assist bot reviewed Oct 10, 2025

View reviewed changes

app/menus/index.js Outdated Show resolved Hide resolved

Yumeo0 added 2 commits October 11, 2025 13:33

misc: use regex from config

596cba2

chore: update package-lock.json

72a53b4

fix: forgor to add "meet"

27ef572

IsmaelMartinez reviewed Oct 12, 2025

View reviewed changes

IsmaelMartinez mentioned this pull request Nov 2, 2025

feat: support short form teams url (simplified) #1915

Merged

3 tasks

IsmaelMartinez closed this Nov 2, 2025

IsmaelMartinez added this to 2.x Nov 2, 2025

IsmaelMartinez added the enhancement New feature or request label Nov 2, 2025

IsmaelMartinez moved this to In Progress in 2.x Nov 2, 2025

IsmaelMartinez moved this from In Progress to Done in 2.x Nov 2, 2025

	`testing RegExp processArgs ${new RegExp(config.allTeamsLinksRegEx).test(
	`testing RegExp processArgs ${new RegExp(config.meetupJoinRegEx).test(

	if (new RegExp(config.allTeamsLinksRegEx).test(arg)) {
	if (new RegExp(config.meetupJoinRegEx).test(arg)) {

	\| `allTeamsLinksRegEx` \| `string` \| `^https://teams\\.(microsoft\|live)\\.com/.*/(?:meetup-join\|channel\|chat\|meet)` \| All Teams-related links regular expression \|
	\| `meetupJoinRegEx` \| `string` \| `^https://teams\\.(microsoft\|live)\\.com/.*/(?:meetup-join\|channel\|chat\|meet)` \| All Teams-related links regular expression \|

Uh oh!

feat: support short form teams url #1869

feat: support short form teams url #1869

Uh oh!

Conversation

Yumeo0 commented Oct 10, 2025

Uh oh!

gemini-code-assist bot commented Oct 10, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

IsmaelMartinez commented Oct 11, 2025

Uh oh!

Yumeo0 commented Oct 11, 2025

Uh oh!

sonarqubecloud bot commented Oct 11, 2025

Quality Gate passed

Uh oh!

IsmaelMartinez left a comment

Choose a reason for hiding this comment

Uh oh!

IsmaelMartinez Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

IsmaelMartinez Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

IsmaelMartinez Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

IsmaelMartinez Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

IsmaelMartinez commented Nov 2, 2025

Uh oh!

Yumeo0 commented Nov 5, 2025

Uh oh!

IsmaelMartinez commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants